Fix bug in wasm preload plugin #19342
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because we were not passing `byteArray` to the onload handle, no data was actually getting written to the fileystem in FS_createPreloadedFile -> processData -> finish and these preloaded files were being written as empty files. This matches the behavior of the other two plugins we have for images and audio. Fixing this bug allows us to fix one of the issues with `test_preload_module`, which is that it was falling back to loading from the a URL if the file was not found. By preloading the file under a different name we prevent the URL fallback from working. The URL fallback had been silently masking the `FS_createPreloadedFile` issue.
kripken
approved these changes
May 12, 2023
Member
|
Good find! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because we were not passing
byteArrayto the onload handle, no data was actually getting written to the fileystem in FS_createPreloadedFile -> processData -> finish and these preloaded files were being written as empty files.This matches the behavior of the other two plugins we have for images and audio.
Fixing this bug allows us to fix one of the issues with
test_preload_module, which is that it was falling back to loading from the a URL if the file was not found. By preloading the file under a different name we prevent the URL fallback from working. The URL fallback had been silently masking theFS_createPreloadedFileissue.