Update libunwind to LLVM 17.0.4 #20705
Conversation
| @@ -196,9 +196,9 @@ | |||
| # define _LIBUNWIND_TARGET_RISCV 1 | |||
| # define _LIBUNWIND_TARGET_VE 1 | |||
| # define _LIBUNWIND_TARGET_S390X 1 | |||
| #define _LIBUNWIND_TARGET_LOONGARCH 1 | |||
| #define _LIBUNWIND_TARGET_LOONGARCH 1 | |||
There was a problem hiding this comment.
Huh, looks like an attempt to fix a typo upstream that failed..? Or is there meaning to indentation like this?
There was a problem hiding this comment.
Yeah it looks someone tried fix an already inconsistent indentation in llvm/llvm-project@d080b5f but didn't get it right... I uploaded llvm/llvm-project#72314 to fix that upstream but given that this doesn't affect our behavior I guess we can just wait until the upstream fix trickles down in the next release.
There was a problem hiding this comment.
Sounds good.
Btw, I don't see a PR for that indentation commit - do people land things in LLVM without review these days?
There was a problem hiding this comment.
Yup, folks have always been able to directly push LLVM.. for better or worse.
No description provided.