Update test_no_legalize_js_ffi in preparation for binaryen change#21599
Merged
sbc100 merged 1 commit intoemscripten-core:mainfrom Mar 23, 2024
Merged
Update test_no_legalize_js_ffi in preparation for binaryen change#21599sbc100 merged 1 commit intoemscripten-core:mainfrom
sbc100 merged 1 commit intoemscripten-core:mainfrom
Conversation
kripken
approved these changes
Mar 23, 2024
Member
kripken
left a comment
kripken
left a comment
There was a problem hiding this comment.
lgtm either way (if there's a reason to keep the test, sgtm)
| assert not e_f32_f64, 'f32 converted to f64 in exports' | ||
| assert e_i64_i64, 'i64 converted to i64 in exports' | ||
|
|
||
| @disabled('https://github.com/WebAssembly/binaryen/pull/6428') |
Member
There was a problem hiding this comment.
Maybe just delete it, as we'll not want to re-enable it?
Collaborator
Author
There was a problem hiding this comment.
I guess its still tests the -sLEGALIZE_JS_FFI=0 setting itself. I guess we should remove this once we remove that setting?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See WebAssembly/binaryen#6428