Split out syscall vararg handling into seperate functions. NFC - #21649
Merged
Conversation
Collaborator
Author
|
Also, includes #21650 for now. diff will be easier to read once that lands. |
sbc100
enabled auto-merge (squash)
March 29, 2024 06:52
sbc100
disabled auto-merge
March 29, 2024 06:52
sbc100
enabled auto-merge (squash)
March 29, 2024 06:52
This means we only include these function when they are needed. As part of a seperate change I was having issue with closure compiler when `SYSCALLS.varargs` are used by never assigned to.
Collaborator
Author
|
ping.. |
kripken
approved these changes
Apr 1, 2024
impact-maker
pushed a commit
to impact-maker/emscripten
that referenced
this pull request
Apr 11, 2024
…ipten-core#21649) * Merge two `SYSCALLS_REQUIRE_FILESYSTEM` blocks. NFC * Split out syscall vararg handling into seperate functions. NFC This means we only include these function when they are needed. As part of a seperate change I was having issue with closure compiler when `SYSCALLS.varargs` are used by never assigned to.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This means we only include these function when they are needed.
As part of a seperate change I was having issue with closure compiler when
SYSCALLS.varargsare used by never assigned to.