Skip to content

Use musl's strptime in standalone mode #22340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 8, 2024

Conversation

sbc100
Copy link
Collaborator

@sbc100 sbc100 commented Aug 8, 2024

This is a less impactful version of #22158

@sbc100
Copy link
Collaborator Author

sbc100 commented Aug 8, 2024

Depends on #22339

@sbc100 sbc100 requested a review from kripken August 8, 2024 20:15
@kripken
Copy link
Member

kripken commented Aug 8, 2024

Depends on #22340

Looks like a circular dependency 🌀 - maybe a typo?

@sbc100
Copy link
Collaborator Author

sbc100 commented Aug 8, 2024

Depends on #22340

Looks like a circular dependency 🌀 - maybe a typo?

Fixed. Just depends on some test cleanups

@sbc100 sbc100 closed this Aug 8, 2024
@sbc100 sbc100 reopened this Aug 8, 2024
@sbc100 sbc100 force-pushed the strptime_standalone branch from 37e904c to db87ffc Compare August 8, 2024 21:25
@sbc100 sbc100 merged commit c6a5bc3 into emscripten-core:main Aug 8, 2024
8 of 12 checks passed
@sbc100 sbc100 deleted the strptime_standalone branch August 8, 2024 21:30
sbc100 added a commit to sbc100/emscripten that referenced this pull request Aug 8, 2024
sbc100 added a commit to sbc100/emscripten that referenced this pull request Aug 8, 2024
sbc100 added a commit that referenced this pull request Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants