-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Remove automatic fallback to $HOME/.emscripten_cache. NFC #22801
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
91990a6
to
79d834c
Compare
Putting the cache in the $HOME directory is not a great idea since its a location that is shared by any/all versions of emscripten. If anyone really wants to use that location they can do so via the config file setting `CACHE` or via the environment variable `EMCC_CACHE`.
79d834c
to
07a319b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
I imagine the link could help someone. Like imagine a dev is maintaining an emcc build that they didn't set up themselves, and it breaks due to this. They aren't a power user and just want to fix it quickly, so the more info we can give them, the better.
is it really expected that emscripten compiler doesn't create --cache/EM_CACHE directories now? Just updated SDK from 3.1.57 and this change affected Github Action pipelines because of |
Sorry, no that was not an indented change in behaviour. Sounds like a case we don't cover in out tests. |
We were incorrectly reporting non-existent parent directories as non-writable. This was broken in emscripten-core#22801.
We were incorrectly reporting non-existent parent directories as non-writable. This was broken in emscripten-core#22801.
We were incorrectly reporting non-existent parent directories as non-writable. This was broken in emscripten-core#22801.
We were incorrectly reporting non-existent parent directories as non-writable. This was broken in emscripten-core#22801.
We were incorrectly reporting non-existent parent directories as non-writable. This was broken in emscripten-core#22801.
We were incorrectly reporting non-existent parent directories as non-writable. This was broken in emscripten-core#22801.
We were incorrectly reporting non-existent parent directories as non-writable. This was broken in emscripten-core#22801.
We were incorrectly reporting non-existent parent directories as non-writable. This was broken in emscripten-core#22801.
We were incorrectly reporting non-existent parent directories as non-writable. This was broken in #22801.
…ore#23049) We were incorrectly reporting non-existent parent directories as non-writable. This was broken in emscripten-core#22801.
Putting the cache in the
$HOME
directory is not a great idea since its a location that is shared by any/all versions of emscripten. If anyone really wants to use that location they can do so via the config file settingCACHE
or via the environment variableEMCC_CACHE
.