-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Trying to create a directory in a file should return ENOTDIR not EPERM #23025
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 7 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
afaf1dc
Trying to create a directory in a file should return ENOTDIR not EPERM
hoodmane 10450a7
Check if isDir first
hoodmane ed283ab
Cleanup
hoodmane d512eb4
Revert memfs change
hoodmane b26e10d
Add test files
hoodmane 23de846
Fix
hoodmane d9ac452
Address review comment
hoodmane 0e7d41a
Fix indentation
hoodmane af64dba
Fix test_unistd_mkdir
hoodmane b93816f
retrigger ci
hoodmane 349d1e8
retrigger ci
hoodmane bce64c4
Merge branch 'main' into enotdir
hoodmane File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
#include <errno.h> | ||
#include <fcntl.h> | ||
#include <stdio.h> | ||
#include <string.h> | ||
#include <unistd.h> | ||
#include <sys/stat.h> | ||
|
||
int main() { | ||
{ | ||
int src_fd = open("file", O_CREAT | O_WRONLY, 0777); | ||
close(src_fd); | ||
} | ||
{ | ||
int target_fd = mkdir("file/blah", 0777); | ||
printf("target_fd: %d, errno: %d %s\n", target_fd, errno, strerror(errno)); | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
target_fd: -1, errno: 54 Not a directory |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -5822,6 +5822,10 @@ def test_fs_write(self): | |
def test_fs_emptyPath(self): | ||
self.do_run_in_out_file_test('fs/test_emptyPath.c') | ||
|
||
@also_with_noderawfs | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Oh I forget to say we should me marking these as @Crossplatform so that they run on windows. |
||
def test_fs_enotdir(self): | ||
self.do_run_in_out_file_test('fs/test_enotdir.c') | ||
|
||
@also_with_noderawfs | ||
def test_fs_append(self): | ||
self.do_runf('fs/test_append.c', 'success') | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2-space indentation.