Avoid explicitly setting .length of wasmTableMirror. NFC
#23836
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
force-pushed
the
remove_explicit_length
branch
from
27cf01f to
a020b43
Compare
kripken
approved these changes
Mar 6, 2025
sbc100
force-pushed
the
remove_explicit_length
branch
from
a020b43 to
4405077
Compare
I added this line myself back in emscripten-core#15286 but I guess I forgot that JS arrays will magically grow on their own.
sbc100
force-pushed
the
remove_explicit_length
branch
from
4405077 to
417cd32
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added this line myself back in #15286 but I guess I forgot that JS arrays will magically grow on their own.