Deprecate RELOCATABLE and LINKABLE settings. #25265
Merged
+21
−32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this is probably what we want; these have been public for long enough that who knows who is doing what with them. Maybe we should cut a release after we land this deprecation but before we start removing things? |
kripken
reviewed
Sep 11, 2025
|
Yes, the plan to would be land this and wait at least a release or two before removal. |
sbc100
force-pushed
the
depracate_linkable_relocatable
branch
2 times, most recently
from
2fb7fcd to
c6424ee
Compare
For some tests that use this flag I simply replaced or removed that flag, for others I added `-Wno-deprecated` for now. See: emscripten-core#25262
sbc100
force-pushed
the
depracate_linkable_relocatable
branch
from
c6424ee to
edc9686
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some tests that use this flag I simply replaced or removed that flag, for others I added
-Wno-deprecatedfor now.See: #25262