Update Vorbis and Ogg ports #25274
Merged
Update Vorbis and Ogg ports #25274
+13
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chkuendig
force-pushed
the
xiph-update
branch
from
1a8bde6 to
f3e4334
Compare
sbc100
reviewed
Sep 15, 2025
|
|
||
|
|
||
| def needed(settings): | ||
| return settings.USE_OGG | ||
|
|
||
|
|
||
| def get(ports, settings, shared): | ||
| ports.fetch_project('ogg', f'https://github.com/emscripten-ports/ogg/archive/{TAG}.zip', sha512hash=HASH) | ||
| ports.fetch_project('ogg', f'https://github.com/xiph/ogg/releases/download/v{VERSION}/libogg-{VERSION}.zip', sha512hash=HASH) |
There was a problem hiding this comment.
We should look into that kind of patches (if any) were applied in the https://github.com/emscripten-ports/ogg/ repo. Where there any changes from upstream?
sbc100
approved these changes
Sep 15, 2025
|
Can you add an entry to the ChangeLog? |
chkuendig
force-pushed
the
xiph-update
branch
from
f3e4334 to
c0d62ab
Compare
Added. |
sbc100
approved these changes
Sep 15, 2025
|
Are these test failures related to this change? They seem to be happening in completely unrelated parts (similar to #25273 which encounters the same problems) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current ogg and vorbis ports are ancient (2015) and pull in repos from the old emscripten-ports github org. From what I can tell, they do not have any patches and both pre-date Xiph.org's migration to Github, so presumably are just old mirrors:
This updates both to the most recent update.(ogg one before the most recent as I haven't yet tested the most recent update)