Fix typos and grammar in enum docs. NFC #26031
Open
+5
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR fixes documentation inconsistencies and improves grammar in the enum bindings section. The main issue was that the ObjectEnum example incorrectly showed enum values as 1 and 2, when C++ enums default to 0-indexed values (0 and 1), which was inconsistent with the other enum type examples.
- Adds missing enum class declaration for better context
- Corrects enum values from 1,2 to 0,1 to match C++ default indexing
- Improves grammar by replacing "Whatever" with "Regardless of"
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
sbc100
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #25257
The main change is that there was an inconsistency in the enum values between the three examples