Skip to content

Add travis build on trusty #5167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Add travis build on trusty #5167

wants to merge 1 commit into from

Conversation

dschuff
Copy link
Member

@dschuff dschuff commented Apr 26, 2017

No description provided.

@dschuff
Copy link
Member Author

dschuff commented Apr 26, 2017

@kripken just for fun I copied your travis file from #5078 and updated for trusty. but i forgot that travis is turned off on GH. Want to try to turn it back on?

@kripken
Copy link
Member

kripken commented Apr 26, 2017

Sure, trying now. But I think in that other PR we got stuck on an emsdk issue that we were waiting for @juj on.

@kripken
Copy link
Member

kripken commented Apr 26, 2017

Enabled. You may need to re-push or something.

@dschuff
Copy link
Member Author

dschuff commented Apr 26, 2017

Looks like it's still failing with a libstdc++ that's too old (it wants a symbol with version GLIBCXX_3.4.21 and it looks like the libstdc++ on trusty only has GLIBCXX_3.4.19.

@dschuff
Copy link
Member Author

dschuff commented Apr 26, 2017

I just tried emsdk on my trusty box and got the same result. Seems like we should fix this on the release builder, it's probably useful to support such systems, and it's not super difficult. If glibc is good and the problem is libstdc++, gcc has a flag --static-libstdc++ that causes libstdc++ to be linked statically.

@kripken
Copy link
Member

kripken commented Apr 26, 2017

Oh nice, that sounds simple. @juj, what do you think?

@aidanhs
Copy link
Contributor

aidanhs commented Apr 27, 2017

If it's linking against a newer libstdc++ that presumably also means it's not being built on trusty? If that's the case I'd imagine it's better to move the release builder itself down to trusty, otherwise glibc compatibility is a problem waiting to happen.

@juj
Copy link
Collaborator

juj commented Apr 28, 2017

@dschuff : which executable is causing the link error? I.e. should we add --static-libstdc++ to link of LLVM/Clang, to Emscripten's optimizer, or to Binaryen executables, or all of those?

@dschuff
Copy link
Member Author

dschuff commented Apr 28, 2017

I imagine we'd need to add it to all of the C++ programs.
BTW, what kind of system are you building these binaries on? A more general solution would be to downgrade it, or to use a sysroot. PNaCl and Chrome are built in a sysroot built from Debian Jessie or Wheezy which makes for a very nice reproducible build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants