Support --trap-mode argument in s2wasm #5620
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should be good, but you'll need to update the binaryen port with this, so that it uses the right version with that flag. |
|
Assuming this is how to update the port and merging to minimize time of inconsistency
If there's anything else I needed to do there let me know |
saschanaz
added a commit
to saschanaz/emscripten
that referenced
this pull request
Oct 6, 2017
`test-binaryen` started to fail on the latest prebuilt SDK 1.37.21 after emscripten-core#5620 as the SDK doesn't support `--trap-mode` yet. Disabling the test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Emscripten side of WebAssembly/binaryen#1210