fix test_time failure in non-DST time zones #5624
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kripken
reviewed
Oct 4, 2017
tests/test_core.py
Outdated
| @@ -2083,7 +2083,16 @@ def test_tcgetattr(self): | |||
| def test_time(self): | |||
| src = open(path_from_root('tests', 'time', 'src.cpp'), 'r').read() | |||
| expected = open(path_from_root('tests', 'time', 'output.txt'), 'r').read() | |||
| self.do_run(src, expected); | |||
| try: | |||
| for tz in ['EST+05EDT', 'UTC+0']: | |||
There was a problem hiding this comment.
Can we keep the current execution without TZ set, that is, that this PR only adds 2 more executions? (can do it before the loop, if so)
src/library.js
Outdated
| @@ -1913,7 +1913,7 @@ LibraryManager.library = { | |||
| var winterOffset = start.getTimezoneOffset(); | |||
| var dstOffset = Math.min(winterOffset, summerOffset); // DST is in December in South | |||
| if (dst < 0) { | |||
| {{{ makeSetValue('tmPtr', C_STRUCTS.tm.tm_isdst, 'Number(dstOffset == guessedOffset)', 'i32') }}}; | |||
| {{{ makeSetValue('tmPtr', C_STRUCTS.tm.tm_isdst, 'Number(summerOffset != winterOffset && dstOffset == guessedOffset)', 'i32') }}}; | |||
There was a problem hiding this comment.
Interesting, so the issue is that some regions don't have DST at all?
Please add a comment mentioning that.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #5617