Skip to content

Run multiple iterations of JSDCE, as more may be removable #5855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Dec 6, 2017
Merged

Conversation

kripken
Copy link
Member

@kripken kripken commented Nov 27, 2017

After we remove a function, it may enable removal of more functions.

Still no full cycle analysis etc. here, so this isn't as good as closure compiler, but it helps a little when not using closure.

Helps #5794

@kripken
Copy link
Member Author

kripken commented Dec 4, 2017

Re-did this. It now does a much better job:

  • Run JSDCE with or without closure. It helps even if closure runs later. As we improve it further it may help more.
  • Add AJSDCE (aggressive JSDCE) which runs multiple iterations. This is enabled on -Os, -Oz builds.
  • Clean up how we add closure testing to tests in test_core.py, and add it to some -Os tests too, not just -O2, for more coverage.

@kripken kripken merged commit 89f9fe5 into incoming Dec 6, 2017
@kripken kripken deleted the jsdce-2 branch December 6, 2017 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant