Perform EXPORT_ALL on SIDE_MODULEs too, avoid special-casing #7319
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t internally [ci skip]
This was referenced Oct 20, 2018
kripken
added a commit
to emscripten-core/emscripten-fastcomp
that referenced
this pull request
Oct 23, 2018
Leave that to the emcc driver to decide. See emscripten-core/emscripten#7319
Beuc
pushed a commit
to Beuc/emscripten
that referenced
this pull request
Nov 17, 2018
This avoids fastcomp doing it internally as a hack, and will allow further improvements for dynamic linking.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids fastcomp doing it internally as a hack, and will allow further improvements for dynamic linking.
This will require a fastcomp change.