Skip to content

[wasm backend] Fix SDL2 + pthreads #8960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 11, 2019
Merged

[wasm backend] Fix SDL2 + pthreads #8960

merged 1 commit into from
Jul 11, 2019

Conversation

kripken
Copy link
Member

@kripken kripken commented Jul 10, 2019

We included the extra SDL2 files for threading, but we were not building any of them with pthreads enabled.

See #8503

@kripken kripken requested review from sbc100 and tlively July 10, 2019 23:36
@kripken kripken mentioned this pull request Jul 10, 2019
Closed
tlively
tlively approved these changes Jul 10, 2019
View reviewed changes
Copy link
Member

@tlively tlively left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we don't care about fastcomp any more we can just use -pthread instead of -s USE_PTHREADS, but I'm not sure that's the case.

@kripken
Copy link
Member Author

kripken commented Jul 11, 2019

Yeah, we still do need fastcomp atm. But we can simply after we remove it.

@kripken kripken merged commit 5e5e79d into incoming Jul 11, 2019
@kripken kripken deleted the sdl2-threads branch July 11, 2019 00:46
@SimplyLiz SimplyLiz mentioned this pull request Feb 12, 2020
Open
belraquib pushed a commit to belraquib/emscripten that referenced this pull request Dec 23, 2020
@kripken @belraquib
[wasm backend] Fix SDL2 + pthreads (emscripten-core#8960)
2b9f3a9 
We included the extra SDL2 files for threading, but we were not building any of them with pthreads enabled.

See emscripten-core#8503
@Asaaj Asaaj mentioned this pull request Mar 21, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tlively tlively tlively approved these changes

@sbc100 sbc100 Awaiting requested review from sbc100

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kripken @tlively