Skip to content

cmake used even when not building from source #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kripken opened this issue Mar 27, 2017 · 1 comment
Open

cmake used even when not building from source #69

kripken opened this issue Mar 27, 2017 · 1 comment

Comments

@kripken
Copy link
Member

kripken commented Mar 27, 2017

I see this on travis in emscripten-core/emscripten#5087

Update complete, however skipped fetching the Emscripten tags, since git was not found.
If you want to compile one of the tagged releases from source, please install git using your package manager, see http://git-scm.com/book/en/Getting-Started-Installing-Git .
If you are not looking to build Emscripten from source, you can safely ignore this message.
Installing SDK 'sdk-tag-1.37.9-64bit'..
Installing tool 'clang-tag-e1.37.9-64bit'..
Downloading: /emsdk-portable/zips/llvm-e1.37.9.tar.gz from https://github.com/kripken/emscripten-fastcomp/archive/1.37.9.tar.gz
Unpacking '/emsdk-portable/zips/llvm-e1.37.9.tar.gz' to '/emsdk-portable/clang/tag-e1.37.9/src'
Downloading: /emsdk-portable/zips/clang-e1.37.9.tar.gz from https://github.com/kripken/emscripten-fastcomp-clang/archive/1.37.9.tar.gz
Unpacking '/emsdk-portable/zips/clang-e1.37.9.tar.gz' to '/emsdk-portable/clang/tag-e1.37.9/src/tools/clang'
Running CMake: ['cmake', '-G', 'Unix Makefiles', '-DCMAKE_BUILD_TYPE=RelWithDebInfo', '-DPYTHON_EXECUTABLE=/usr/bin/python', '-DLLVM_TARGETS_TO_BUILD=X86;JSBackend', '-DLLVM_INCLUDE_EXAMPLES=OFF', '-DCLANG_INCLUDE_EXAMPLES=OFF', '-DLLVM_INCLUDE_TESTS=OFF', '-DCLANG_INCLUDE_TESTS=OFF', '-DLLVM_ENABLE_ASSERTIONS=ON', '/emsdk-portable/clang/tag-e1.37.9/src']

It should just be getting the binary now, as reported on the mailing list, I think? Not sure why it's running cmake? (and is it downloading the sources too?)

@juj
Copy link
Collaborator

juj commented Jun 15, 2017

Ops sorry, this one skipped through my emails. I wonder if you were able to resolve this yet?

The issue here is that sdk-tag-1.37.9-64bit is an "compile-from-source" SDK. The precompiled SDKs don't have the word "tag" in them, so sdk-1.37.9-64bit is a precompiled one.

I agree that the naming is a bit odd. The way this is attempted to be clarified is when running ./emsdk list. That command categorizes SDKs under "compile-from-source" and "precompiled" headings to try to clarify.

vargaz pushed a commit to vargaz/emsdk that referenced this issue Nov 22, 2023
* Include .msi files in post build signing (emscripten-core#68)

* Apply feedback from dotnet#68

* Apply feedback from dotnet#45

Co-authored-by: Matt Mitchell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants