Switch default backend from 'fastcomp' to 'upstream' #373
Conversation
sbc100
force-pushed
the
upstream_by_default
branch
from
572ae99 to
9e7f798
Compare
sbc100
requested review from
kripken and
dschuff
and removed request for
kripken
|
Before we land this we should have docs probably, but I'm not sure where? |
|
Actually, maybe we could have the emsdk say something? Like show a message, "the default backend has changed" on first run after the change? |
|
Good idea. Added a bit notice. |
sbc100
force-pushed
the
upstream_by_default
branch
from
5efc809 to
aabbf8d
Compare
|
Looks good, thanks! |
|
In offline discussion we had the idea to maybe not always default to upstream, but just from 1.39.0 and onwards. The idea being that say at a version from last year, upstream's support was not that great yet, so it would be bad. Only at 1.39.0 are we confident the new backend is good enough for general use. Let's discuss more and decide next week. |
sbc100
force-pushed
the
upstream_by_default
branch
from
aabbf8d to
588d8bb
Compare
|
Updated so that we now only default for upstream for 'latest' and for 1.39.0 and above. |
sbc100
changed the title
sbc100
force-pushed
the
upstream_by_default
branch
from
588d8bb to
12a6db9
Compare
sbc100
changed the title
When users as for 'latest' or just '1.39.0' we now default to the upstream llvm backend. For versions before 1.39.0 we continue to default to fastcomp. Fixes: emscripten-core/emscripten#5488
sbc100
force-pushed
the
upstream_by_default
branch
from
12a6db9 to
25835aa
Compare
| if arg in ('latest', 'sdk-latest', 'latest-64bit', 'sdk-latest-64bit', 'latest-fastcomp', 'latest-releases-fastcomp'): | ||
| if arg in ('latest', 'sdk-latest', 'latest-64bit', 'sdk-latest-64bit'): | ||
| # This is effectly the default SDK | ||
| report_upstream_by_default() |
There was a problem hiding this comment.
I think we can report this only if the version is high enough? Can maybe share code with the existing check later down.
There was a problem hiding this comment.
The version check make sense below, but here we know that we want to unconditionally select upstream right? We never want latest to point to fastcomp ever again, do we? And if we do we would revert this code.
|
🎉🎉🎉 |
Enable SxS manifests for workloads
When users as for 'latest' or just '1.39.0' we now default to the upstream llvm backend.
For versions before 1.39.0 we continue to default to fastcomp.
Fixes: emscripten-core/emscripten#5488