WRN-12124: Remove deprecated babel-eslint module #261

hong6316 · 2022-03-11T02:01:57Z

Issue Resolved / Feature Added

babel-eslint has been deprecated

`babel-eslint` is now `@babel/eslint-parser`. This package will no longer receive updates.

Resolution

Removed deprecated babel-eslint

Additional Considerations

When you release the new @enact/cli version with this PR, you should update npm-shrinkwrap.json.

$ rm -rf npm-shrinkwrap.json
$ npm i
$ npm audit fix
$ npm shrinkwrap

Links

WRN-12124

Comments

Enact-DCO-1.0-Signed-off-by: Taeyoung Hong ([email protected])

This reverts commit 1b8b37e.

This reverts commit b8579cb.

This reverts commit b73146a.

MikyungKim

babel-eslint is remained in README.md. Please update that too.

hong6316 · 2022-03-21T08:48:25Z

babel-eslint is remained in README.md. Please update that too.

@MikyungKim
I checked README.md and I remained this word first with in my opinion.
Because this description is the guide for removing previous modules that are no longer used.
(and customers will remove babel-eslint that we intended)

But anyway, I remove the word babel-eslint in README.md.

README.md

MikyungKim

Please add a change log.

package.json

Co-authored-by: Mikyung Kim <[email protected]>

README.md

Co-authored-by: Mikyung Kim <[email protected]>

Enact-DCO-1.0-Signed-off-by: Mikyung Kim ([email protected])

MikyungKim

LGTM

* WRN-18582: Migrate to webpack5 (#264) * WRN-18582: webpack5 initial commit Enact-DCO-1.0-Signed-off-by: Mikyung Kim ([email protected]) * WRN-18582: Fixed serve issue Enact-DCO-1.0-Signed-off-by: Mikyung Kim ([email protected]) * WRN-18582: Added webpack cache config Enact-DCO-1.0-Signed-off-by: Mikyung Kim ([email protected]) * applied more changes Enact-DCO-1.0-Signed-off-by: Mikyung Kim ([email protected]) * Added changelog Enact-DCO-1.0-Signed-off-by: Mikyung Kim ([email protected]) * fix Enact-DCO-1.0-Signed-off-by: Mikyung Kim ([email protected]) * update `listen` to `startCallback` from webpack dev server Enact-DCO-1.0-Signed-off-by: Mikyung Kim ([email protected]) * fix filename..ext issue Enact-DCO-1.0-Signed-off-by: Mikyung Kim ([email protected]) * WRN-16762: Added support for tailwindcss and update dependencies (#263) * initial modules update(before wp5 update) * npm audit fix * Update package.json * fix lint errors * update CHANGELOG.md * Update package.json * revert CHANGELOG.mx * revert jest 27 * revert npm-shrinkwrap.json * revert pack/serve.js * for removing conflict with #262, revert versions * Update react-refresh-webpack-plugin version Co-authored-by: Mikyung Kim <[email protected]> * Update babel-jest version Co-authored-by: Mikyung Kim <[email protected]> * Update babel-plugin-dev-expression version Co-authored-by: Mikyung Kim <[email protected]> * remove unnecessary code * revert file permission * update dependencies * update package.json * Update package.json Co-authored-by: Mikyung Kim <[email protected]> * Update package.json * fix Enact-DCO-1.0-Signed-off-by: Mikyung Kim ([email protected]) Co-authored-by: Mikyung Kim <[email protected]> * update changelog and package.json Enact-DCO-1.0-Signed-off-by: Mikyung Kim ([email protected]) Co-authored-by: taeyoung.hong <[email protected]> * WRN-12124: Remove deprecated babel-eslint module (#261) * use @babel/eslint-parser * remove babel-preset-react-app * remove @babel/eslint-parser * Revert "remove @babel/eslint-parser" This reverts commit 1b8b37e. * Revert "remove babel-preset-react-app" This reverts commit b8579cb. * Revert "use @babel/eslint-parser" This reverts commit b73146a. * babel-eslint -> @babel/eslint-parser * unpinning enact repos * remove babel-eslint related word in README.md * Update README.md * modify changelog & readme * Update package.json Co-authored-by: Mikyung Kim <[email protected]> * Update README.md Co-authored-by: Mikyung Kim <[email protected]> * update npm-shrinkwrap.json * update @babel/core to the same version of dev-utils Enact-DCO-1.0-Signed-off-by: Mikyung Kim ([email protected]) * Move some dependencies to dev dependencies Enact-DCO-1.0-Signed-off-by: Mikyung Kim ([email protected]) Co-authored-by: Mikyung Kim <[email protected]> * WRN-19252: Pass ProgressPlugin to VerboseLogPlugin (#265) Enact-DCO-1.0-Signed-off-by: Mikyung Kim ([email protected]) * WRN-12748: Update eslint 8 related modules (#262) * update eslint 8 * eslint 8 changes strict package exports(#14706), call another method * revert js changes * Update package.json * restore eslintrc.js - 'prettier' (included 'prettier/babel', 'prettier/react') * Update package.json Co-authored-by: Mikyung Kim <[email protected]> Co-authored-by: Mikyung Kim <[email protected]> * WRN-19694: Update to React18 (#266) * update react version Enact-DCO-1.0-Signed-off-by: Mikyung Kim ([email protected]) * update testing library for react18 Enact-DCO-1.0-Signed-off-by: Mikyung Kim ([email protected]) * update react version Enact-DCO-1.0-Signed-off-by: Mikyung Kim ([email protected]) * update dependencies Enact-DCO-1.0-Signed-off-by: Mikyung Kim ([email protected]) * update version Enact-DCO-1.0-Signed-off-by: Mikyung Kim ([email protected]) * update dev-utils branch Enact-DCO-1.0-Signed-off-by: Mikyung Kim ([email protected]) * revert dev-utils version Enact-DCO-1.0-Signed-off-by: Mikyung Kim ([email protected]) * WRN-20481: Fix screenshot test build fail (#267) * Added node-polyfill-webpack-plugin Enact-DCO-1.0-Signed-off-by: Mikyung Kim ([email protected]) * added some comments Enact-DCO-1.0-Signed-off-by: Mikyung Kim ([email protected]) * link dev-utils Enact-DCO-1.0-Signed-off-by: Mikyung Kim ([email protected]) * WRN-20481: Fix lint error and revert packages version Enact-DCO-1.0-Signed-off-by: Mikyung Kim ([email protected]) * update change log Enact-DCO-1.0-Signed-off-by: Mikyung Kim ([email protected]) * update dependencies Enact-DCO-1.0-Signed-off-by: Mikyung Kim ([email protected]) Co-authored-by: taeyoung.hong <[email protected]>

hong6316 added 8 commits March 8, 2022 15:36

use @babel/eslint-parser

b73146a

remove babel-preset-react-app

b8579cb

remove @babel/eslint-parser

1b8b37e

Revert "remove @babel/eslint-parser"

31fc3cf

This reverts commit 1b8b37e.

Revert "remove babel-preset-react-app"

378c1b8

This reverts commit b8579cb.

Revert "use @babel/eslint-parser"

031920c

This reverts commit b73146a.

babel-eslint -> @babel/eslint-parser

999c705

unpinning enact repos

2dfcb59

hong6316 requested review from MikyungKim March 11, 2022 05:20

MikyungKim changed the base branch from develop to feature/webpack5 March 21, 2022 07:47

MikyungKim reviewed Mar 21, 2022

View reviewed changes

hong6316 and others added 3 commits March 21, 2022 17:49

remove babel-eslint related word in README.md

935b4d8

Merge branch 'feature/webpack5' into feature/WRN-12124

3910712

Update README.md

444f22a

MikyungKim reviewed Mar 24, 2022

View reviewed changes

README.md Show resolved Hide resolved

MikyungKim reviewed Mar 24, 2022

View reviewed changes

modify changelog & readme

6ee38b3

MikyungKim reviewed Mar 24, 2022

View reviewed changes

package.json Outdated Show resolved Hide resolved

Update package.json

ffd3b67

Co-authored-by: Mikyung Kim <[email protected]>

MikyungKim reviewed Mar 24, 2022

View reviewed changes

README.md Outdated Show resolved Hide resolved

hong6316 and others added 4 commits March 24, 2022 16:50

Update README.md

5b06ad5

Co-authored-by: Mikyung Kim <[email protected]>

update npm-shrinkwrap.json

3d340dd

update @babel/core to the same version of dev-utils

4c20781

Enact-DCO-1.0-Signed-off-by: Mikyung Kim ([email protected])

Move some dependencies to dev dependencies

2f563a4

Enact-DCO-1.0-Signed-off-by: Mikyung Kim ([email protected])

MikyungKim approved these changes Mar 25, 2022

View reviewed changes

MikyungKim merged commit 826d927 into feature/webpack5 Mar 25, 2022

MikyungKim deleted the feature/WRN-12124 branch March 25, 2022 05:36

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

WRN-12124: Remove deprecated babel-eslint module #261

WRN-12124: Remove deprecated babel-eslint module #261

Uh oh!

hong6316 commented Mar 11, 2022 •

edited by MikyungKim

Loading

Uh oh!

MikyungKim left a comment

Uh oh!

hong6316 commented Mar 21, 2022

Uh oh!

Uh oh!

MikyungKim left a comment

Uh oh!

Uh oh!

Uh oh!

MikyungKim left a comment

Uh oh!

Uh oh!

WRN-12124: Remove deprecated babel-eslint module #261

WRN-12124: Remove deprecated babel-eslint module #261

Uh oh!

Conversation

hong6316 commented Mar 11, 2022 • edited by MikyungKim Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Issue Resolved / Feature Added

Resolution

Additional Considerations

Links

Comments

Uh oh!

MikyungKim left a comment

Choose a reason for hiding this comment

Uh oh!

hong6316 commented Mar 21, 2022

Uh oh!

Uh oh!

MikyungKim left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

MikyungKim left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

hong6316 commented Mar 11, 2022 •

edited by MikyungKim

Loading