WRR-14491: Update dev-utils to support Limestone #143
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hong6316
commented
Jan 20, 2025
| @@ -79,7 +79,7 @@ class SnapshotPlugin { | |||
| const filter = lib => (resource, context) => { | |||
| return resource.startsWith(lib) && context === ignoreContext; | |||
| }; | |||
| ['@enact/i18n', '@enact/moonstone', '@enact/sandstone', '@enact/core/snapshot'].filter(missing).forEach(p => { | |||
| ['@enact/i18n', '@enact/moonstone', '@enact/sandstone', '@enact/limestone', '@enact/core/snapshot'].filter(missing).forEach(p => { | |||
There was a problem hiding this comment.
Should moonstone needs to be kept in here?
hong6316
commented
Jan 20, 2025
| @@ -11,7 +11,7 @@ var ExecutionEnvironment = require('fbjs/lib/ExecutionEnvironment'); | |||
|
|
|||
| function handleException(e) { | |||
| // We allow 'Cannot find module' errors, which throw when the libraries are not used in the app. | |||
| // @enact/i18n, @enact/moonstone, and @enact/sandstone are considered optional dependencies. | |||
| // @enact/i18n, @enact/moonstone, @enact/sandstone, and @enact/limestone are considered optional dependencies. | |||
There was a problem hiding this comment.
Should @enact/moonstone needs to be kept in here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Issue Resolved / Feature Added
Update dev-utils to support Limestone
Resolution
Additional Considerations
Links
WRR-14491
Comments
Enact-DCO-1.0-Signed-off-by: Taeyoung Hong ([email protected])