Add ValidationError to except in get_object_or_404 for django 1.11 #5126
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for the fix. |
6 tasks
eigenein
reviewed
Dec 27, 2017
| @@ -18,7 +19,7 @@ def get_object_or_404(queryset, *filter_args, **filter_kwargs): | |||
| """ | |||
| try: | |||
| return _get_object_or_404(queryset, *filter_args, **filter_kwargs) | |||
| except (TypeError, ValueError): | |||
| except (TypeError, ValueError, ValidationError): | |||
There was a problem hiding this comment.
Shouldn't it re-raise it as a DRF validation error?
There was a problem hiding this comment.
The method is get_object_or_404, the raise Http404 here is to keep it consistent with the get_object_or_404 method that is implemented within the Django core.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add
ValidationErrortoexceptinrest_framework.generics.get_object_or_404to handle change in Django 1.11 whereget_object_or_404returns aValidationError(as opposed to earlier versions that returned aValueError) when passing an invalid value for theuuid.Refs #3377 (I'd be happy to open up a separate issue for this as well, but wasn't sure if I should)