Skip to content

Fixes instance check in ListSerializer.to_representation (#8726) #8727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Nov 22, 2022
Merged

Fixes instance check in ListSerializer.to_representation (#8726) #8727

Changes from 2 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
e52d4e8
Fixes 'RelatedManager' object is not iterable in ListSerializer.to_re…
954-Ivory Oct 24, 2022
61becb6
Change to only BaseManager
954-Ivory Oct 24, 2022
c9b6b02
Merge branch 'encode:master' into fix_instance_check
954-Ivory Nov 21, 2022
2137b1e
Commit unit test
954-Ivory Nov 22, 2022
c3f343b
Update tests/test_serializer_lists.py
auvipy Nov 22, 2022
20b7ac7
Merge branch 'encode:master' into fix_instance_check
954-Ivory Nov 22, 2022
1fe232e
Update tests/test_serializer_lists.py
auvipy Nov 22, 2022
2741f06
Update tests/test_serializer_lists.py
auvipy Nov 22, 2022
adc5ad6
Update tests/test_serializer_lists.py
auvipy Nov 22, 2022
c3ee838
Update tests/test_serializer_lists.py
auvipy Nov 22, 2022
0aa817c
Update tests/test_serializer_lists.py
auvipy Nov 22, 2022
fbe3de3
Format import
954-Ivory Nov 22, 2022
85eb12e
Format import
954-Ivory Nov 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion rest_framework/serializers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -681,7 +681,7 @@ def to_representation(self, data):
"""
# Dealing with nested relationships, data can be a Manager,
# so, first get a queryset from the Manager if needed
iterable = data.all() if isinstance(data, models.Manager) else data
iterable = data.all() if isinstance(data, models.manager.BaseManager) else data
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I triggered the CI, can you please pull from main branch again? the bug was not verify able in the test suite, would you mind investigate further to figure out if we can add some relevant test for this?

Copy link
Contributor Author

@954-Ivory 954-Ivory Nov 21, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I triggered the CI, can you please pull from main branch again? the bug was not verify able in the test suite, would you mind investigate further to figure out if we can add some relevant test for this?

Yes, but it may take a while.
I'm a little hungry. I'm going to cook dinner first. 😋

Is that what you mean? ( My English is not good )

  1. Append the test case.
  2. Merge this branch to master in my fork ( I'm not sure about this ).
  3. Then pull request again (encode:master from 954-ivory:master).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I meant pull from encode:master to your working branch for this PR 954-ivory:master so that the recently updated versions in CI could reflect here. And some unit tests :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the rebase, now just appending/adding additional test cases would be really great


return [
self.child.to_representation(item) for item in iterable
Expand Down