Skip to content

Catch exception if close() in exception manager, throw another except… #1020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pprados
Copy link

@pprados pprados commented Jun 25, 2025

Given this is a project maintained by volunteers, please read this template to not waste your time, or ours! 😁 -->

Summary

If some scenario, to close the program, the code catch en exception, and try to close itself. But, if this close generate and exception, the code crash with a stacktrace.

    async def __aiter__(self) -> typing.AsyncIterator[bytes]:
        try:
            async for part in self._stream:
                yield part
        except BaseException as exc:
            try:
                await self.aclose()
            except BaseException:
                pass
            raise exc from None

Checklist

  • I understand that this PR may be closed in case there was no previous discussion. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant