Skip to content

Rename URLMatcher -> URLPattern #1109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 1, 2020
Merged

Rename URLMatcher -> URLPattern #1109

merged 2 commits into from
Aug 1, 2020

Conversation

florimondmanca
Copy link
Member

@florimondmanca florimondmanca commented Aug 1, 2020 •
edited
Loading

Prompted by #977 (comment) (which I agree with :-))

(Note that I've renamed URLMatcher in this example case, since I think httpx.URLPattern might be a better name)

@florimondmanca florimondmanca added the refactor Issues and PRs related to code refactoring label Aug 1, 2020
tomchristie
tomchristie approved these changes Aug 1, 2020
View reviewed changes
Copy link
Member

@tomchristie tomchristie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic yup!

If we ever end up making it public we'd want to move a bunch of the attributes into private names too, but no big need to resolve that atm.

@florimondmanca florimondmanca merged commit 71d5234 into master Aug 1, 2020
@florimondmanca florimondmanca deleted the urlpattern branch August 1, 2020 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomchristie tomchristie tomchristie approved these changes

Assignees
No one assigned
Labels
refactor Issues and PRs related to code refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@florimondmanca @tomchristie