Skip to content

Type error on invalid url type #1259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

wozniakty
Copy link
Contributor

Closes #1258

Note: first contribution, so let me know if I'm missing anything

Copy link
Member

@florimondmanca florimondmanca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat little contribution — definitely see the point in preventing users from using other types named URL from related libraries.

A nit, but approving in advance…

@wozniakty wozniakty force-pushed the type-error-on-invalid-url-type branch from 6c993b4 to 62d08df Compare September 4, 2020 21:07
@wozniakty wozniakty force-pushed the type-error-on-invalid-url-type branch from 62d08df to eac4390 Compare September 4, 2020 21:10
Copy link
Member

@florimondmanca florimondmanca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@florimondmanca florimondmanca merged commit 42c6686 into encode:master Sep 4, 2020
@tomchristie tomchristie mentioned this pull request Sep 21, 2020
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Confusing error messages when passing in the wrong URL type
2 participants