`overrideDebug` reports do not render Errors correctly, just `{}`

[michaelfig]

Describe the bug

The overrideDebug reports no longer output error messages and stack traces. This makes debugging code with many modules impossible to find where something trips over the override mistake.

Steps to reproduce

1. Go to the top of the endo checkout
2. yarn install
3. Run sh ./repro.sh, whose contents are:

#! /bin/sh
DEBUG_LOCKDOWN_OPTIONS='{"errorTaming":"unsafe","stackFiltering":"verbose","overrideTaming":"severe","overrideDebug":["constructor"]}'

cat <<EOF > ./override-mistake.mjs
import '@endo/init';

const o = new Object();
o.constructor = 42;
EOF
LOCKDOWN_OPTIONS=$DEBUG_LOCKDOWN_OPTIONS node ./override-mistake.mjs

4. Observe output:

$ ./repro.sh
'@endo/lockdown' sniffed and found a 'LOCKDOWN_OPTIONS' environment variable

SES Enabling property overrides
  {}
$

Note that the Error, whose stack trace would have given valuable debugging information, is rendered just as {}.

Expected behavior

Render an error indicating the constructor override mistake instead of just {}.

Platform environment

• What OS are you using? macOS Sequoia 15.5
• What version of Node.js? v20.18.3
• Is there anything special/unusual about your platform? No, not really.
• What version of Endo are you using? @endo/import-bundle@1.5.2-9-g0927be926

Additional context

n/a

Screenshots

Console output as above, not pretty pictures.

[erights]

@mfig, when I follow your repro instructions on Node 20 I get exactly the buggy symptoms you report. On Node 18, I get the full diagnostic we expect:

'@endo/lockdown' sniffed and found a 'LOCKDOWN_OPTIONS' environment variable

SES Enabling property overrides
  [TypeError <Object <Object <[Object: null prototype] {}>>>: Override property constructor
  at set constructor (file:///Users/markmiller/src/ongithub/endojs/endo/packages/ses/src/enable-property-overrides.js:116:22)
  at file:///Users/markmiller/src/ongithub/endojs/endo/override-mistake.mjs:4:15
  at ModuleJob.run (node:internal/modules/esm/module_job:195:25)
  at async ModuleLoader.import (node:internal/modules/esm/loader:336:24)
  at async loadESM (node:internal/process/esm_loader:34:7)
  at async handleMainPromise (node:internal/modules/run_main:106:12)]

I don't yet know what the relevant change is from Node 18 to Node 20. But to unblock whatever you're doing, try switching to Node 18.

[erights]

The problem is specific to the constructor property and the overrideTaming level of "moderate" or "severe". Switching to toString` and "min"

#! /bin/sh
DEBUG_LOCKDOWN_OPTIONS='{"errorTaming":"unsafe","stackFiltering":"verbose","overrideTaming":"min","overrideDebug":["toString"]}'

cat <<EOF > ./override-mistake.mjs
import '@endo/init';

const o = new Object();
o.toString = 42;
EOF
LOCKDOWN_OPTIONS=$DEBUG_LOCKDOWN_OPTIONS node ./override-mistake.mjs

and running on Node 20 produces the expected output

'@endo/lockdown' sniffed and found a 'LOCKDOWN_OPTIONS' environment variable

SES Enabling property overrides
  [TypeError: Override property toString
  at set toString (file:///Users/markmiller/src/ongithub/endojs/endo/packages/ses/src/enable-property-overrides.js:116:22)
  at file:///Users/markmiller/src/ongithub/endojs/endo/override-mistake.mjs:4:12
  at ModuleJob.run (node:internal/modules/esm/module_job:234:25)
  at async ModuleLoader.import (node:internal/modules/esm/loader:473:24)
  at async asyncRunEntryPointWithESMLoader (node:internal/modules/run_main:122:5)]

Notice that the first correct output has the <Object <Object <[Object: null prototype] {}>>> noise whereas the later does not. This is likely because TypeError.constructor is still a data property. But breaking it down by cases from there gives me behavior that I cannot make sense of.

In any case, I still suspect the underlying cause is Node's behavior around objects whose constructor is an accessor.

See #636 and #944

@michaelfig , where is that node-derived inspect function you were showing me?

[erights]

Very striking is @kumavis ' example at #944 (comment) where "min" and "severe" are working and similar and "moderate" prints as {}. OTOH this was a long time ago, so I don't know yet if it will reproduce.

[erights]

The symptoms go away if we use our causal console rather than the Node platform console, because we render errors to text ourselves before passing it on to the platform console. Hence #2934

[erights]

The snippet at #636 has grown into the code at

https://github.com/nodejs/node/blob/fc3f19ef932444e8de5d69fe3fb5033b2e0ec2e4/lib/internal/util/inspect.js#L627

If the prototypes whose constructors we make into accessors were added to wellKnownPrototypes, our problems my well disappear.

[erights]

using #2934 as of right now, the outputs from @michaelfig 's test case on each recent node

Node 18:

'@endo/lockdown' sniffed and found a 'LOCKDOWN_OPTIONS' environment variable

SES Enabling property overrides
  (TypeError#1)
TypeError#1: Override property constructor
  at set constructor (file:///Users/markmiller/src/ongithub/endojs/endo/packages/ses/src/enable-property-overrides.js:116:22)
  at file:///Users/markmiller/src/ongithub/endojs/endo/override-mistake.mjs:4:15
  at ModuleJob.run (node:internal/modules/esm/module_job:195:25)
  at async ModuleLoader.import (node:internal/modules/esm/loader:336:24)
  at async loadESM (node:internal/process/esm_loader:34:7)
  at async handleMainPromise (node:internal/modules/run_main:106:12)

Node 20:

'@endo/lockdown' sniffed and found a 'LOCKDOWN_OPTIONS' environment variable

SES Enabling property overrides
  (TypeError#1)
TypeError#1: Override property constructor
  at set constructor (file:///Users/markmiller/src/ongithub/endojs/endo/packages/ses/src/enable-property-overrides.js:116:22)
  at file:///Users/markmiller/src/ongithub/endojs/endo/override-mistake.mjs:4:15
  at ModuleJob.run (node:internal/modules/esm/module_job:234:25)
  at async ModuleLoader.import (node:internal/modules/esm/loader:473:24)
  at async asyncRunEntryPointWithESMLoader (node:internal/modules/run_main:122:5)

Node 22 (original has colors):

'@endo/lockdown' sniffed and found a 'LOCKDOWN_OPTIONS' environment variable

SES Enabling property overrides
  (TypeError#1)
TypeError#1: Override property constructor
  at set constructor (file:///Users/markmiller/src/ongithub/endojs/endo/packages/ses/src/enable-property-overrides.js:116:22)
  at file:///Users/markmiller/src/ongithub/endojs/endo/override-mistake.mjs:4:15
  at ModuleJob.run (node:internal/modules/esm/module_job:262:25)
  at async onImport.tracePromise.__proto__ (node:internal/modules/esm/loader:485:26)
  at async asyncRunEntryPointWithESMLoader (node:internal/modules/run_main:109:5)

Node 24 (original has no colors):

'@endo/lockdown' sniffed and found a 'LOCKDOWN_OPTIONS' environment variable

SES Enabling property overrides
  (TypeError#1)
TypeError#1: Override property constructor
  at set constructor (file:///Users/markmiller/src/ongithub/endojs/endo/packages/ses/src/enable-property-overrides.js:116:22)
  at file:///Users/markmiller/src/ongithub/endojs/endo/override-mistake.mjs:4:15
  at ModuleJob.run (node:internal/modules/esm/module_job:327:25)
  at async onImport.tracePromise.__proto__ (node:internal/modules/esm/loader:663:26)
  at async asyncRunEntryPointWithESMLoader (node:internal/modules/run_main:99:5)

[erights]

See also nodejs/node#59456