Skip to content

Remove apt cache #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
777shuang wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove apt cache #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,10 @@ ARG target_arch
ENV PATH=/opt/cegcc-${target_arch}/bin:$PATH

RUN apt update && \
DEBIAN_FRONTEND=noninteractive apt install -y --no-install-recommends bison build-essential ca-certificates flex git libgmp-dev libmpc-dev libmpfr-dev texinfo
apt upgrade -y && \
Copy link

@Freax13 Freax13 Jun 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a good reason for running apt upgrade? Wouldn't it be more appropriate to use a newer base image version?

Copy link
Author

@777shuang 777shuang Aug 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh
I made a mistake.

DEBIAN_FRONTEND=noninteractive apt install -y --no-install-recommends bison build-essential ca-certificates flex git libgmp-dev libmpc-dev libmpfr-dev texinfo && \
apt clean && \
Copy link

@Freax13 Freax13 Jun 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
apt clean && \

The debian docker image automatically runs apt clean after every install invocation.

rm -rf /var/lib/apt/lists/*

RUN git clone --depth 1 --recursive --shallow-submodules https://github.com/enlyze/cegcc-build && \
cd cegcc-build && \
Expand Down