Replace usage of adapt from traits.protocols.api #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
with adapt from traits.adaptaion.api modified: codetools/contexts/with_mask.py
Contributor
Author
|
same failure as seen in #25 |
The underlying traits pickling machinery seems to be broken with the latest release i.e. 5.0.0, leading to broken pickling of MultiContext instances on Python 2. Given the move to Python 3, this has been deemed an acceptable bug on Python 2 so we skip the failing test. modified: codetools/contexts/tests/multi_context_test_case.py
Skip persistence test for MultiContext - Py2
Codecov Report
@@ Coverage Diff @@
## master #27 +/- ##
======================================
Coverage 44.7% 44.7%
======================================
Files 72 72
Lines 4586 4586
Branches 970 970
======================================
Hits 2050 2050
Misses 2346 2346
Partials 190 190
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
with
adaptfromtraits.adaptaion.api. This API was removed with the latest release of traits i.e. 5.0.0.