Repository navigation
Modernize Python versions used in CI workflows - #624
Merged
Merged
Conversation
The workflows using actions/setup-python fall into two groups: those needing a single Python, and the one testing across a matrix. Single-version jobs now all use Python 3.14. Six already did; the two bootstrap Pythons that run etstool.py for the EDM workflows were still on 3.10. The test-with-pypi matrix gains Python 3.15. Since 3.15 has no stable release yet, setup-python needs allow-prereleases to resolve it; the flag has no effect on the matrix entries that do have a stable release, so it can stay in place once 3.15 ships. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Every PySide6 release caps Requires-Python below the newest version in the test matrix; 6.11.1 declares ">=3.10,<3.15". pip honours that cap, so "pip install pyside6" failed outright on the 3.15 job and the matrix produced no toolkit coverage there. The cap is conservatism about untested Python versions rather than a real incompatibility: PySide6 ships abi3 wheels, and 6.11.1 installed that way runs the full Envisage suite on 3.15 without failures, GUI tests included. uv reaches the same outcome by ignoring Requires-Python upper bounds, which is why local runs under uv never saw the problem. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This was referenced Aug 5, 2026
mdickinson
added a commit
that referenced
this pull request
Aug 5, 2026
A review of the 8.0.0 changelog against `7.0.4..main`. 7.0.4 was tagged directly on main — `0c02d0b` is both the tag commit and the merge-base — so that range is exact. It holds 30 non-merge commits: 11 touching the library or packaging, 19 CI and infrastructure. ## The library side was already complete All eight substantive changes had entries, and both deprecations 7.0.0 promised to remove in 8.0 (#540, #544) are removed and listed. No `DeprecationWarning` remains anywhere in the library, so nothing is left dangling for 9.0. ## References now point at PRs, not issues The two `Fixes` entries for the `HTTPError` leak cited #615, whose title is "Clean up test noise from warnings and WARNING-level log messages". The leak was found *via* that cleanup, but a reader following the reference lands on a test-hygiene issue rather than a resource-leak fix. Rather than fix those two in isolation, every reference in the section now points at the PR that made the change: #574→#613, #616→#622, #548→#599, #547→#612, #614→#617, and #615→#618/#619/#621 as appropriate. This also supplies the reference the `pkg_resources` entry was missing — #600, the PR, rather than #515, the issue. Two notes: - The "no longer writes `WARNING`-level log messages" entry cites **both** #618 and #621. #618 deliberately deferred the four `envisage.ui.tasks.tasks` records from the `TasksApplication` tests to a follow-up, so the claim only became true once #621 landed. - Sections for 7.0.4 and earlier are untouched; they already cite PRs. ## CI and build work added Nineteen PRs had no entry at all, in contrast with 7.0.4, which listed its action bumps and copyright-header updates under `Build`. Five new entries cover them, aggregated where the work was one theme: | Entry | PRs | | --- | --- | | Trusted publishing (OIDC) and SHA-pinned actions | #604, #608 | | Copyright end years, and the year-rollover fix to the style check | #596, #597, #607 | | GitHub Action bumps | #591, #592, #593, #594, #595, #602, #603, #605, #606, #609, #610 | | Pre-release Pythons in the CI matrix | #601, #624 | | `AGENTS.md` | #598, #626 | Trusted publishing changes how releases are authenticated, so it seemed worth naming rather than folding into the general CI churn. ## Judgment calls worth a second opinion **The CI matrix entry names no versions.** It reads "now includes pre-release Python versions" rather than "3.14, and 3.15 pre-releases". Naming them is more informative, but in a section whose `Removals` entry deliberately gives no upper bound on supported Pythons, a `Build` line ending in "3.15" invites exactly the reading that bound was left out to avoid. Easy to change if you'd rather have the numbers. **No upper bound on Python versions.** Considered and rejected: it means churn on every Python release, and forwards compatibility is the reasonable default expectation for a package that runs warning-free on the current version. **Deliberate omissions.** #626's other cleanups — an `IServiceRegistry` docstring, the legacy examples README, dead Traits<6.0 test code — change nothing for users. There's no `Documentation` section because the doc edits in #599 are just the egg-manager material going away with the classes, already covered by the `Removals` entry. And `CorePlugin` gaining its own `stop()` to unregister service offers is an implementation move; the #617 entry already notes that `PluginActivator` no longer calls `register_services`/`unregister_services`, which is the part a downstream `Plugin` subclass would notice. ## Left to the release PR The `Released:` date line, an introductory paragraph, a "Thanks to:" list, and the `version = '7.0.4'` still in `pyproject.toml`. The date isn't settled yet. ## Verification `CHANGES.rst` parses under docutils with no warnings at report level 2 or above, and all lines stay within 79 characters. Changelog only — no code touched. 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The workflows using
actions/setup-pythonfall into two groups: those thatjust need a single Python, and the one that tests across a matrix. This brings
the first group up to 3.14 and adds 3.15 to the second.
Six of the single-version jobs were already on 3.14:
check-style,check-style-strict,test-doc-build,publish-on-pypi,update-gh-pagesand
update-gh-pages-on-release. The two that were not are the bootstrapPythons that run
etstool.pyfor the EDM workflows, both still on 3.10. Thoseenvironments only install
clickand shell out toedm, which supplies itsown interpreter, so nothing there was version-sensitive.
test-with-pypigains Python 3.15. Since 3.15 has no stable release yet,setup-pythonwill not resolve it withoutallow-prereleases; that flag is ano-op for the entries that do have a stable release, so it can stay in place
unchanged once 3.15 ships. At the moment it resolves to 3.15.0rc1.
Installing the Qt toolkit there needs
--ignore-requires-python. EveryPySide6 release caps
Requires-Pythonbelow the newest matrix entry — 6.11.1declares
>=3.10,<3.15— and pip honours that cap, so a plainpip install pyside6fails outright on 3.15. The cap reflects conservatismabout untested Python versions rather than a real incompatibility: PySide6
ships abi3 wheels, and 6.11.1 installed that way runs the whole Envisage suite
on 3.15 without failures, GUI tests included. uv arrives at the same outcome by
ignoring
Requires-Pythonupper bounds, which is why this never surfaces whenrunning the tests locally under uv.
Verified by reproducing the job's steps with pip in a Python 3.15 virtual
environment: PySide6 6.11.1 installs,
traitsbuilds from sdist, and the fullsuite passes all 178 tests.
traitspublishes no cp315 wheel for eitherlinux-x86_64 or macos-arm64, so the 3.15 job compiles it and will be
correspondingly slower than its siblings. That check ran on macOS arm64 against
3.15.0b2, so it differs from the runner's ubuntu x86_64 and 3.15.0rc1.
🤖 Generated with Claude Code