Skip to content

Move edm.yaml under .github - #634

Merged
mdickinson merged 2 commits into
mainfrom
move-edm-config
Aug 6, 2026
Merged

mdickinson merged 2 commits into
mainfrom
move-edm-config

Conversation

@mdickinson

Copy link
Copy Markdown
Member

edm.yaml sat at the top level but has exactly one consumer, the two edm install steps in test-with-edm.yml, so it moves to .github/edm.yaml.

Not .github/workflows/: that directory is specified as the place for workflow
files, and a tool config isn't one.

git mv plus the two --config paths, and nothing else references it. The
sdist and wheel are unaffected — uv_build ships only the package directory
alongside the readme and licence files, so edm.yaml was never in either.

test-with-edm runs on pull_request, so the four EDM jobs here exercise the
new path directly.

This PR was created with the assistance of an AI coding agent.

Its only consumer is test-with-edm.yml, and it was adding noise to the
top level of the repository. Not .github/workflows/, which is where
workflow files go.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@mdickinson
mdickinson requested a review from Copilot August 6, 2026 15:20

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR relocates the EDM configuration file from the repository root to .github/edm.yaml, aligning its location with its sole consumer (the test-with-edm GitHub Actions workflow) while keeping packaging artifacts unchanged.

Changes:

  • Move edm.yaml into .github/edm.yaml.
  • Update edm install steps in test-with-edm.yml to use --config .github/edm.yaml.

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.

File Description
.github/workflows/test-with-edm.yml Updates workflow steps to reference the moved EDM config file path.
.github/edm.yaml Adds the EDM configuration under .github/ to match its usage in CI.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/test-with-edm.yml Resolved
@mdickinson
mdickinson merged commit 4e3e35f into main Aug 6, 2026
44 of 45 checks passed
@mdickinson
mdickinson deleted the move-edm-config branch August 6, 2026 15:36
mdickinson added a commit that referenced this pull request Aug 7, 2026
Closes #653.

Prepares the 8.0.1 release:

* Retitle the in-development changelog section from `8.1.0` to `8.0.1`,
and
  replace the `Released: YYYY-MM-DD` placeholder with today's date.
* Add the overview, in the style used for earlier bugfix releases, and
credit
  contributors since 8.0.0 under `Thanks to`.
* Bump the version in `pyproject.toml` from 8.0.0 to 8.0.1, and refresh
  `uv.lock`, which pins the project's own version. (8.0.0 predated the
  lockfile, so this step is new since the last release.)

Three PRs merged since the 8.0.0 tag had no changelog entry, so this
adds
them: the ruff reformat (#642), folded into the entry for the PR that
configured ruff (#637), the `edm.yaml` move (#634), and the
`pypa/gh-action-pypi-publish` bump (#633). #650 is deliberately left
out,
since it only edited the changelog. Happy to drop #633 and #634 if you'd
rather keep the release notes to things a reader of them would act on.

Pre-flight, beyond CI: `uv build` and `twine check --strict` both pass,
and
`uv sync --locked` confirms the refreshed lockfile.

Diffing the 8.0.1 artifacts against the released 8.0.0 ones shows one
difference that isn't explained by the changes since 8.0.0: the sdist
now
carries a `pyproject.toml.orig` beside a `pyproject.toml` that has been
rewritten and stripped of its comments. That is `uv_build` working as
designed — since uv 0.12.0 it always rewrites the sdist's
`pyproject.toml`
as TOML 1.0, so that older build frontends can consume it, and preserves
the
original alongside. The two parse to identical data. It arrived with
#628,
along with the switch to `uv_build`, and needs no action.

*This PR was created with the assistance of an AI coding agent.*

---------

Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants