Skip to content

feat: add template for quota policy rl server and service - #2214

Draft
aabchoo wants to merge 3 commits into
envoyproxy:mainfrom
aabchoo:aaron/creat-quota-policy-template
Draft

feat: add template for quota policy rl server and service#2214
aabchoo wants to merge 3 commits into
envoyproxy:mainfrom
aabchoo:aaron/creat-quota-policy-template

Conversation

@aabchoo

@aabchoo aabchoo commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Description

Helm template to create quota policy rate limit server and service. The template is derived from the backend_quota_ratelimit.yaml. Guarded by a feature flag

Related to #2177

Signed-off-by: achoo30 <achoo30@bloomberg.net>
@aabchoo
aabchoo requested a review from a team as a code owner June 9, 2026 15:03
@dosubot dosubot Bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Jun 9, 2026
@aabchoo aabchoo changed the title feat: add template for quota policy feat: add template for quota policy rl server and service Jun 9, 2026
@codecov-commenter

codecov-commenter commented Jun 9, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.50%. Comparing base (1db3a15) to head (33f5a90).
⚠️ Report is 63 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2214   +/-   ##
=======================================
  Coverage   84.50%   84.50%           
=======================================
  Files         144      144           
  Lines       21055    21055           
=======================================
  Hits        17792    17792           
  Misses       2188     2188           
  Partials     1075     1075           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aabchoo

aabchoo commented Jun 9, 2026

Copy link
Copy Markdown
Contributor Author

/gemini review

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a Helm template and default configuration values for deploying a quota-based rate limiter service for the AI Gateway. The feedback highlights opportunities to improve the Helm chart's flexibility and correctness, including fixing a cut-off comment in the deployment template, using the tpl function to evaluate template expressions within environment variables, and replacing a hardcoded namespace with {{ .Release.Namespace }} for dynamic resolution.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread manifests/charts/ai-gateway-helm/templates/quota_policy_rate_limit.yaml Outdated
Comment thread manifests/charts/ai-gateway-helm/values.yaml
aabchoo added 2 commits June 9, 2026 11:14
Signed-off-by: achoo30 <achoo30@bloomberg.net>
Signed-off-by: achoo30 <achoo30@bloomberg.net>
@aabchoo
aabchoo marked this pull request as draft June 9, 2026 19:21
@missBerg missBerg added the area/quota Rate limiting, quota, token/cost accounting and attribution label Jul 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/quota Rate limiting, quota, token/cost accounting and attribution size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants