Skip to content

translator: add nil checks for tool call ids before dereferencing the pointers - #2242

Merged
nacx merged 4 commits into
envoyproxy:mainfrom
nacx:translator-nil-check
Jun 22, 2026
Merged

translator: add nil checks for tool call ids before dereferencing the pointers#2242
nacx merged 4 commits into
envoyproxy:mainfrom
nacx:translator-nil-check

Conversation

@nacx

@nacx nacx commented Jun 17, 2026

Copy link
Copy Markdown
Member

Description

Adds nil checks for tool call IDs before dereferencing the pointers.

Related Issues/PRs (if applicable)

N/A

Special notes for reviewers (if applicable)

N/A

…ointers

Signed-off-by: Ignasi Barrera <nacx@apache.org>
@nacx
nacx requested a review from a team as a code owner June 17, 2026 08:43
@dosubot dosubot Bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Jun 17, 2026
@codecov-commenter

codecov-commenter commented Jun 17, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.69%. Comparing base (21d65d6) to head (c59e431).

Files with missing lines Patch % Lines
internal/translator/anthropic_helper.go 0.00% 2 Missing and 1 partial ⚠️
internal/translator/gemini_helper.go 0.00% 1 Missing and 1 partial ⚠️
internal/translator/openai_awsbedrock.go 0.00% 1 Missing and 1 partial ⚠️

❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2242      +/-   ##
==========================================
- Coverage   84.71%   84.69%   -0.02%     
==========================================
  Files         144      144              
  Lines       21217    21224       +7     
==========================================
+ Hits        17973    17975       +2     
- Misses       2162     2165       +3     
- Partials     1082     1084       +2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nacx
nacx enabled auto-merge (squash) June 17, 2026 09:06
@nacx

nacx commented Jun 22, 2026

Copy link
Copy Markdown
Member Author

/retest

@missBerg

Copy link
Copy Markdown
Contributor

/retest

1 similar comment
@nacx

nacx commented Jun 22, 2026

Copy link
Copy Markdown
Member Author

/retest

@nacx
nacx merged commit 7eead6c into envoyproxy:main Jun 22, 2026
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants