Skip to content

controller: add consistency check for gateway object namespaces - #2274

Merged
nacx merged 2 commits into
envoyproxy:mainfrom
nacx:controller-ns-consistency
Jun 22, 2026
Merged

controller: add consistency check for gateway object namespaces#2274
nacx merged 2 commits into
envoyproxy:mainfrom
nacx:controller-ns-consistency

Conversation

@nacx

@nacx nacx commented Jun 22, 2026

Copy link
Copy Markdown
Member

Description

The previous gateway controller code made assumptions about the namespace consistency across gateway resources. This change adds an explicit check and returns an error if there are inconsistencies.

Related Issues/PRs (if applicable)

N/A

Special notes for reviewers (if applicable)

N/A

Signed-off-by: Ignasi Barrera <ignasi@tetrate.io>
@nacx
nacx requested a review from a team as a code owner June 22, 2026 20:23
@dosubot dosubot Bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Jun 22, 2026
@codecov-commenter

codecov-commenter commented Jun 22, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 72.72727% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.70%. Comparing base (6214f8b) to head (77d52f4).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/controller/gateway.go 72.72% 6 Missing and 3 partials ⚠️

❌ Your patch status has failed because the patch coverage (72.72%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2274   +/-   ##
=======================================
  Coverage   84.70%   84.70%           
=======================================
  Files         144      144           
  Lines       21206    21214    +8     
=======================================
+ Hits        17962    17970    +8     
  Misses       2162     2162           
  Partials     1082     1082           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nacx
nacx enabled auto-merge (squash) June 22, 2026 20:39
@nacx
nacx merged commit 8766e8c into envoyproxy:main Jun 22, 2026
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants