Skip to content

mcp: cover all branches on nil checks for json response - #2275

Merged
nacx merged 1 commit into
envoyproxy:mainfrom
nacx:mcp-nil-check
Jun 22, 2026
Merged

mcp: cover all branches on nil checks for json response#2275
nacx merged 1 commit into
envoyproxy:mainfrom
nacx:mcp-nil-check

Conversation

@nacx

@nacx nacx commented Jun 22, 2026

Copy link
Copy Markdown
Member

Description

Fix the a nil check on MCP session to capture all branches.

Related Issues/PRs (if applicable)

N/A

Special notes for reviewers (if applicable)

N/A

Signed-off-by: Ignasi Barrera <ignasi@tetrate.io>
@nacx
nacx requested a review from a team as a code owner June 22, 2026 20:59
@dosubot dosubot Bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Jun 22, 2026
@nacx
nacx enabled auto-merge (squash) June 22, 2026 21:07
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.70%. Comparing base (8766e8c) to head (30eab5e).

Files with missing lines Patch % Lines
internal/mcpproxy/handlers.go 0.00% 4 Missing ⚠️

❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2275   +/-   ##
=======================================
  Coverage   84.70%   84.70%           
=======================================
  Files         144      144           
  Lines       21214    21214           
=======================================
  Hits        17970    17970           
  Misses       2162     2162           
  Partials     1082     1082           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nacx
nacx merged commit 7f61335 into envoyproxy:main Jun 22, 2026
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants