Skip to content
This repository was archived by the owner on Dec 16, 2020. It is now read-only.

wasm: restructure wasm test flakes for bazel build #488

Closed
wants to merge 11 commits into from

Conversation

Shikugawa
Copy link
Member

@Shikugawa Shikugawa commented Apr 21, 2020

Signed-off-by: shikugawa [email protected]

For an explanation of how to fill out the fields, please see the relevant section
in PULL_REQUESTS.md

Description: This is a part of cleanup of wasm build with bazel. I'm planning to restructure directories related with wasm for testing like below.

test/extensions/
  └ wasm_data/
        ├ WORKSPACE
        ├ .bazelrc
        ├ BUILD
        ├ bazel            # bazel settings
        ├ access_loggers   # moved from test/extensions/access_loggers/wasm/test_data
	├ common           # moved from test/extensions/common/wasm/test_data
	├ functionality    # moved from test/extensions/wasm/test_data
        └ filter
           ├ network       # L4 wasm filters
           └ http          # L7 wasm filters
  • null_plugin build
  • proxy_wasm in Rust build with bazel
  • bazel in bazel approach to build them from root
  • test all of wasm with single bazel command. build wasm and test

Risk Level: Low
Testing:
Docs Changes:
Release Notes:
[Optional Fixes #Issue]
[Optional Deprecated:]

Signed-off-by: shikugawa <[email protected]>
@Shikugawa Shikugawa changed the title wasm: restructure for bazel build wasm: restructure wasm test flakes for bazel build Apr 21, 2020
@PiotrSikora
Copy link
Contributor

What's the purpose of this change?

@Shikugawa
Copy link
Member Author

Shikugawa commented Apr 23, 2020

@PiotrSikora This is only cleanup. It seems that we will be suffered from the complexity of the directory structure for wasm for testing. I think that we should aggregate the data. So we need this, I see.
I want to destroy and aggregate these directories in the future.

test/extensions/wasm/test_data
test/extensions/common/wasm/test_data
test/extensions/filters/http/wasm/test_data
test/extensions/filters/network/wasm/test_data
test/extensions/access_loggers/wasm/test_data

Signed-off-by: shikugawa <[email protected]>
lizan and others added 9 commits April 24, 2020 21:53
Signed-off-by: Lizan Zhou <[email protected]>
Signed-off-by: Lizan Zhou <[email protected]>
Signed-off-by: Lizan Zhou <[email protected]>
Signed-off-by: Lizan Zhou <[email protected]>
Signed-off-by: shikugawa <[email protected]>
Signed-off-by: shikugawa <[email protected]>
Signed-off-by: shikugawa <[email protected]>
Signed-off-by: shikugawa <[email protected]>
@Shikugawa
Copy link
Member Author

Close this PR because I want to apply transition based wasm build in another.

@Shikugawa Shikugawa closed this May 8, 2020
@Shikugawa Shikugawa deleted the wasm-bazel-1 branch May 8, 2020 05:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants