Skip to content

Conversation

@abeyad
Copy link
Contributor

@abeyad abeyad commented May 17, 2024

No description provided.

@abeyad
Copy link
Contributor Author

abeyad commented May 17, 2024

/assign-from @envoyproxy/senior-maintainers

@repokitteh-read-only
Copy link

@envoyproxy/senior-maintainers assignee is @yanavlasov

🐱

Caused by: a #34232 (comment) was created by @abeyad.

see: more, trace.

@abeyad abeyad enabled auto-merge (squash) May 17, 2024 16:12
@abeyad
Copy link
Contributor Author

abeyad commented May 17, 2024

/retest

@abeyad abeyad merged commit b65de1f into envoyproxy:main May 17, 2024
@botengyao
Copy link
Member

@abeyad @fredyw Just run into this for our import, and do we need any improvement for the CI to catch this problem?

@fredyw
Copy link
Member

fredyw commented May 23, 2024

@abeyad @fredyw Just run into this for our import, and do we need any improvement for the CI to catch this problem?

Yeah, we are planning to enable CI with xDS enabled to catch this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants