Support drop_overload using EDS cache while CDS update warming failure #42949
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yanjun Xiang <[email protected]>
Contributor
Author
|
/assign @yurykats |
Signed-off-by: Yanjun Xiang <[email protected]>
Contributor
Author
|
/assign @yanavlasov |
yurykats
reviewed
Jan 12, 2026
| void EdsClusterImpl::update( | ||
| const envoy::config::endpoint::v3::ClusterLoadAssignment& cluster_load_assignment) { | ||
| // Drop overload configuration parsing. | ||
| THROW_IF_NOT_OK(parseDropOverloadConfig(cluster_load_assignment)); |
Contributor
There was a problem hiding this comment.
It seems to me that since update() is void, it's not expected to be doing any error checking. Maybe just log that overload wasn't applied and move on?
Contributor
Author
There was a problem hiding this comment.
As discussed offline, we want to reject the bad configuration by throwing an exception. This follows the same logic as other EDS updates.
Contributor
|
LGTM |
Contributor
Author
|
/assign @adisuissa |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a problem that during CDS update, the drop_overload in Envoy memory is wiped out. If EDS update never arrives, the drop_overload enforcement is lost, and only start to function after next EDS update arrives.
This PR fixes this issue by moving the drop_overload parsing logic to a common function update() which will cover both EDS succeeds cases and EDS timeout cases.