Skip to content

split it cases into multiple classes#333

Merged
rultor merged 6 commits into
masterfrom
306
May 22, 2023
Merged

split it cases into multiple classes#333
rultor merged 6 commits into
masterfrom
306

Conversation

@h1alexbel

@h1alexbel h1alexbel commented May 22, 2023

Copy link
Copy Markdown
Member

closes #306


PR-Codex overview

This PR introduces Kafka Integration Tests and deprecates EntryTest. It also adds KafkaRunsTest, ConsumerTest, and ProducerTest classes.

Detailed summary

  • Adds Kafka Integration Tests
  • Deprecates EntryTest
  • Adds KafkaRunsTest, ConsumerTest, and ProducerTest classes

The following files were skipped due to too many changes: src/it/producer-consumer-api/src/test/java/ProducerTest.java, src/it/producer-consumer-api/src/test/java/ProducerConsumerTest.java

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@zoeself

zoeself commented May 22, 2023

Copy link
Copy Markdown
Collaborator

@h1alexbel thank you for your Pull Request. I'll assign someone to review it soon.

If this PR solves a todo from the code, please don't forget to remove it.

@h1alexbel h1alexbel changed the title it cases split into multiple classes split it cases into multiple classes May 22, 2023
@zoeself

zoeself commented May 22, 2023

Copy link
Copy Markdown
Collaborator

@l3r8yJ please review this Pull Request. Deadline (when it should be merged or closed) is 2023-05-25T09:12:20.137895.

You should check if the requirements have been implemented (partially or in full), if there are unit tests covering the changes and if the CI build passes. Feel free to reject the PR or ask for changes if it's too big or not clear enough.

Estimation here is 30 minutes, that's how much you will be paid. You will be paid even if this PR gets rejected.

@codecov

codecov Bot commented May 22, 2023

Copy link
Copy Markdown

Codecov Report

Patch and project coverage have no change.

Comparison is base (1342766) 96.27% compared to head (934481f) 96.27%.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #333   +/-   ##
=========================================
  Coverage     96.27%   96.27%           
  Complexity      126      126           
=========================================
  Files            61       61           
  Lines           295      295           
=========================================
  Hits            284      284           
  Misses           11       11           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@h1alexbel
h1alexbel requested a review from l3r8yJ May 22, 2023 09:13
@h1alexbel
h1alexbel removed the request for review from l3r8yJ May 22, 2023 15:04
@h1alexbel

Copy link
Copy Markdown
Member Author

@zoeself deregister

@zoeself

zoeself commented May 22, 2023

Copy link
Copy Markdown
Collaborator

@zoeself deregister

@h1alexbel ok, I've removed this task from scope. I'm not managing it anymore.

@h1alexbel

Copy link
Copy Markdown
Member Author

@rultor merge

@rultor

rultor commented May 22, 2023

Copy link
Copy Markdown
Collaborator

@rultor merge

@h1alexbel OK, I'll try to merge now. You can check the progress of the merge here

@rultor
rultor merged commit 934481f into master May 22, 2023
@rultor

rultor commented May 22, 2023

Copy link
Copy Markdown
Collaborator

@rultor merge

@h1alexbel Done! FYI, the full log is here (took me 2min)

@h1alexbel
h1alexbel deleted the 306 branch May 22, 2023 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

EntryTest.java:70: Split ITCases into multiple files

5 participants