Skip to content

migration to Synchronized xfake 0.1.2 storage#349

Merged
rultor merged 2 commits into
masterfrom
314
May 31, 2023
Merged

migration to Synchronized xfake 0.1.2 storage#349
rultor merged 2 commits into
masterfrom
314

Conversation

@h1alexbel

@h1alexbel h1alexbel commented May 31, 2023

Copy link
Copy Markdown
Member

closes #348


PR-Codex overview

This PR deprecates an old class and updates dependencies. It also adds synchronization to an existing test.

Detailed summary

  • Deprecates ImmutableReentrantLock class
  • Updates xfake version to 0.1.2
  • Adds Synchronized wrapper to InXmlTest test setup method.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@zoeself

zoeself commented May 31, 2023

Copy link
Copy Markdown
Collaborator

@h1alexbel thank you for your Pull Request. I'll assign someone to review it soon.

If this PR solves a todo from the code, please don't forget to remove it.

@zoeself

zoeself commented May 31, 2023

Copy link
Copy Markdown
Collaborator

@h1alexbel please review this Pull Request. Deadline (when it should be merged or closed) is 2023-06-03T14:52:20.437099.

You should check if the requirements have been implemented (partially or in full), if there are unit tests covering the changes and if the CI build passes. Feel free to reject the PR or ask for changes if it's too big or not clear enough.

Estimation here is 30 minutes, that's how much you will be paid. You will be paid even if this PR gets rejected.

@h1alexbel

Copy link
Copy Markdown
Member Author

@rultor merge

@codecov

codecov Bot commented May 31, 2023

Copy link
Copy Markdown

Codecov Report

Patch and project coverage have no change.

Comparison is base (49ca4dc) 96.27% compared to head (821ceb9) 96.27%.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #349   +/-   ##
=========================================
  Coverage     96.27%   96.27%           
  Complexity      126      126           
=========================================
  Files            61       61           
  Lines           295      295           
=========================================
  Hits            284      284           
  Misses           11       11           
Impacted Files Coverage Δ
...qrs/kafka/fake/storage/ImmutableReentrantLock.java 100.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@rultor

rultor commented May 31, 2023

Copy link
Copy Markdown
Collaborator

@rultor merge

@h1alexbel OK, I'll try to merge now. You can check the progress of the merge here

@rultor
rultor merged commit 42f194c into master May 31, 2023
@rultor

rultor commented May 31, 2023

Copy link
Copy Markdown
Collaborator

@rultor merge

@h1alexbel Done! FYI, the full log is here (took me 2min)

@h1alexbel
h1alexbel deleted the 314 branch May 31, 2023 15:02
@zoeself

zoeself commented May 31, 2023

Copy link
Copy Markdown
Collaborator

@h1alexbel thank you for resolving this ticket. I've just added it to your active invoice. You can always check all your invoices and more on the Contributor Dashboard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

migrate to xfake 0.1.2

3 participants