-
Notifications
You must be signed in to change notification settings - Fork 4
fake consumer unsubscribes #388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
63 changes: 63 additions & 0 deletions
63
src/main/java/io/github/eocqrs/kafka/fake/UnsubscribeDirs.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,63 @@ | ||
| /* | ||
| * Copyright (c) 2023 Aliaksei Bialiauski, EO-CQRS | ||
| * | ||
| * Permission is hereby granted, free of charge, to any person obtaining a copy | ||
| * of this software and associated documentation files (the "Software"), to deal | ||
| * in the Software without restriction, including without limitation the rights | ||
| * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell | ||
| * copies of the Software, and to permit persons to whom the Software is | ||
| * furnished to do so, subject to the following conditions: | ||
| * | ||
| * The above copyright notice and this permission notice shall be included in all | ||
| * copies or substantial portions of the Software. | ||
| * | ||
| * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR | ||
| * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, | ||
| * FITNESS FOR A PARTICULAR PURPOSE AND NON-INFRINGEMENT. IN NO EVENT SHALL THE | ||
| * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER | ||
| * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, | ||
| * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE | ||
| * SOFTWARE. | ||
| */ | ||
|
|
||
| package io.github.eocqrs.kafka.fake; | ||
|
|
||
| import org.cactoos.Scalar; | ||
| import org.xembly.Directives; | ||
|
|
||
| import java.util.UUID; | ||
|
|
||
| /** | ||
| * Unsubscribe Directives. | ||
| * | ||
| * @author Aliaksei Bialiauski (abialiauski.dev@gmail.com) | ||
| * @since 0.3.5 | ||
| */ | ||
| public final class UnsubscribeDirs implements Scalar<Directives> { | ||
|
|
||
| /** | ||
| * Consumer ID. | ||
| */ | ||
| private final UUID consumer; | ||
|
|
||
| /** | ||
| * Ctor. | ||
| * | ||
| * @param cnsmr Consumer ID | ||
| */ | ||
| public UnsubscribeDirs(final UUID cnsmr) { | ||
| this.consumer = cnsmr; | ||
| } | ||
|
|
||
| @Override | ||
| public Directives value() throws Exception { | ||
| return new Directives() | ||
| .xpath("broker/subs/sub[consumer = '%s']/consumer" | ||
| .formatted( | ||
| this.consumer | ||
| ) | ||
| ) | ||
| .remove() | ||
| .remove(); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
53 changes: 53 additions & 0 deletions
53
src/test/java/io/github/eocqrs/kafka/fake/UnsubscribeDirsTest.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,53 @@ | ||
| /* | ||
| * Copyright (c) 2023 Aliaksei Bialiauski, EO-CQRS | ||
| * | ||
| * Permission is hereby granted, free of charge, to any person obtaining a copy | ||
| * of this software and associated documentation files (the "Software"), to deal | ||
| * in the Software without restriction, including without limitation the rights | ||
| * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell | ||
| * copies of the Software, and to permit persons to whom the Software is | ||
| * furnished to do so, subject to the following conditions: | ||
| * | ||
| * The above copyright notice and this permission notice shall be included in all | ||
| * copies or substantial portions of the Software. | ||
| * | ||
| * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR | ||
| * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, | ||
| * FITNESS FOR A PARTICULAR PURPOSE AND NON-INFRINGEMENT. IN NO EVENT SHALL THE | ||
| * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER | ||
| * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, | ||
| * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE | ||
| * SOFTWARE. | ||
| */ | ||
|
|
||
| package io.github.eocqrs.kafka.fake; | ||
|
|
||
| import org.hamcrest.MatcherAssert; | ||
| import org.hamcrest.Matchers; | ||
| import org.junit.jupiter.api.Test; | ||
|
|
||
| import java.util.UUID; | ||
|
|
||
| /** | ||
| * Test case for {@link UnsubscribeDirs}. | ||
| * | ||
| * @author Aliaksei Bialiauski (abialiauski.dev@gmail.com) | ||
| * @since 0.3.5 | ||
| */ | ||
| final class UnsubscribeDirsTest { | ||
|
|
||
| @Test | ||
| void dirsInRightFormat() throws Exception { | ||
| final UUID uuid = UUID.fromString("1ce12119-7ccc-46fc-a993-36d5b815a7b5"); | ||
| final String directives = "XPATH \"broker/subs/sub" | ||
| + "[consumer = '1ce12119-7ccc-46fc-a993-36d5b815a7b5']/consumer\";" | ||
| + "\n1:REMOVE;REMOVE;"; | ||
| MatcherAssert.assertThat( | ||
| "Directives in right format", | ||
| new UnsubscribeDirs(uuid) | ||
| .value() | ||
| .toString(), | ||
| Matchers.equalTo(directives) | ||
| ); | ||
| } | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@l3r8yJ Unfortunately it is not possible to mix the params using extensions
if we need a
UUIDExtensionandConsumerExtension:when creating a consumer, we need a UUID from the extension, that generates it
but I can't take this generated parameter
Then, if we decide to make only one
ConsumerExtension, in following assertion we don't have parameter uuid:maybe I missing something, especially in getting parameters from another extension
WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@l3r8yJ also, this test case (unsubscribes) requires testing consumers with the same broker