Skip to content

Fake consumer records#392

Merged
h1alexbel merged 7 commits into
masterfrom
fake-consumer
Jun 27, 2023
Merged

Fake consumer records#392
h1alexbel merged 7 commits into
masterfrom
fake-consumer

Conversation

@h1alexbel

@h1alexbel h1alexbel commented Jun 27, 2023

Copy link
Copy Markdown
Member

@l3r8yJ take a look, please

closes #303


PR-Codex overview

This PR adds functionality to the Kafka fake consumer, including support for various data types and a timeout for reading records. It also includes some minor changes and bug fixes.

Detailed summary

  • Added support for various data types in the Kafka fake consumer.
  • Added a timeout for reading records in the Kafka fake consumer.
  • Minor changes and bug fixes in various files.

The following files were skipped due to too many changes: src/main/java/io/github/eocqrs/kafka/fake/FkRecords.java, src/test/java/io/github/eocqrs/kafka/fake/FkConsumerTest.java

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@zoeself

zoeself commented Jun 27, 2023

Copy link
Copy Markdown
Collaborator

@h1alexbel thank you for your Pull Request. I'll assign someone to review it soon.

If this PR solves a todo from the code, please don't forget to remove it.

@codecov

codecov Bot commented Jun 27, 2023

Copy link
Copy Markdown

Codecov Report

Patch coverage: 94.11% and project coverage change: +0.37 🎉

Comparison is base (b94a78d) 97.86% compared to head (216b068) 98.23%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #392      +/-   ##
============================================
+ Coverage     97.86%   98.23%   +0.37%     
- Complexity      157      164       +7     
============================================
  Files            73       75       +2     
  Lines           421      453      +32     
  Branches          1        1              
============================================
+ Hits            412      445      +33     
+ Misses            9        8       -1     
Impacted Files Coverage Δ
...n/java/io/github/eocqrs/kafka/fake/FkConsumer.java 95.55% <83.33%> (-4.45%) ⬇️
.../java/io/github/eocqrs/kafka/fake/DatasetDirs.java 100.00% <100.00%> (ø)
...in/java/io/github/eocqrs/kafka/fake/FkRecords.java 100.00% <100.00%> (ø)
...ain/java/io/github/eocqrs/kafka/fake/SeenDirs.java 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@zoeself

zoeself commented Jun 27, 2023

Copy link
Copy Markdown
Collaborator

@l3r8yJ please review this Pull Request. Deadline (when it should be merged or closed) is 2023-06-30T08:59:10.193683.

You should check if the requirements have been implemented (partially or in full), if there are unit tests covering the changes and if the CI build passes. Feel free to reject the PR or ask for changes if it's too big or not clear enough.

Estimation here is 30 minutes, that's how much you will be paid. You will be paid even if this PR gets rejected.

@h1alexbel

Copy link
Copy Markdown
Member Author

@l3r8yJ unfortunately FkConsumer#125-126 cannot be covered

@h1alexbel h1alexbel requested a review from l3r8yJ June 27, 2023 15:12

@l3r8yJ l3r8yJ left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@h1alexbel looks cool, just 1 small fix

Comment thread src/main/java/io/github/eocqrs/kafka/fake/FkRecords.java Outdated
Co-authored-by: Ivan Ivanchuk <clicker.heroes.acg@gmail.com>
@l3r8yJ

l3r8yJ commented Jun 27, 2023

Copy link
Copy Markdown
Member

@h1alexbel I also suggest to set this flag to false for cases like this

fail_ci_if_error: true

@h1alexbel h1alexbel merged commit e93a62a into master Jun 27, 2023
@h1alexbel h1alexbel deleted the fake-consumer branch June 27, 2023 19:28
@zoeself

zoeself commented Jun 27, 2023

Copy link
Copy Markdown
Collaborator

@l3r8yJ thank you for resolving this ticket. I've just added it to your active invoice. You can always check all your invoices and more on the Contributor Dashboard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

FkConsumer.java:66: Fake records is not implemented

3 participants