Skip to content

Packages, consumer#48

Merged
h1alexbel merged 7 commits into
eo-cqrs:masterfrom
l3r8yJ:packages_consumer
Feb 25, 2023
Merged

Packages, consumer#48
h1alexbel merged 7 commits into
eo-cqrs:masterfrom
l3r8yJ:packages_consumer

Conversation

@l3r8yJ

@l3r8yJ l3r8yJ commented Feb 25, 2023

Copy link
Copy Markdown
Member

@h1alexbel take a look, please

here are some changes for packages and I tried to create a Consumer interface. I'm not sure about Consumer, what do you think?

@l3r8yJ l3r8yJ requested a review from h1alexbel February 25, 2023 12:03
@codecov-commenter

codecov-commenter commented Feb 25, 2023

Copy link
Copy Markdown

Codecov Report

Base: 93.10% // Head: 93.10% // No change to project coverage 👍

Coverage data is based on head (76c6376) compared to base (83a8e75).
Patch has no changes to coverable lines.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff            @@
##             master      #48   +/-   ##
=========================================
  Coverage     93.10%   93.10%           
  Complexity       12       12           
=========================================
  Files             6        6           
  Lines            29       29           
=========================================
  Hits             27       27           
  Misses            2        2           
Impacted Files Coverage Δ
src/main/java/org/eocqrs/kafka/data/KfData.java 100.00% <ø> (ø)
...rc/main/java/org/eocqrs/kafka/data/KfDataized.java 100.00% <ø> (ø)
...ain/java/org/eocqrs/kafka/producer/KfProducer.java 100.00% <ø> (ø)
.../org/eocqrs/kafka/producer/KfProducerSettings.java 100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

*/
public interface Consumer<X> {

void consume(int partition, Data<X> message);

@h1alexbel h1alexbel Feb 25, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@l3r8yJ , I believe that this method should return some data. But which type of the data? Maybe for now we can go with simple puzzle

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have some ideas: we can return Dataized and then turn it in the real data fetched by the consumer

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean turning object into some data

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@h1alexbel take a look, please at this

public interface Consumer<X> {

void consume(int partition, Data<X> message);
Dataized<?> consume(int partition, Data<X> message);

@h1alexbel h1alexbel Feb 25, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. To consume data we need partition and other meta information (original KafkaConsumer can help)
  2. I would name this method not consume, but dataized[read this]
  3. finally, maybe we need a puzzle

what do you think @l3r8yJ

@l3r8yJ

l3r8yJ commented Feb 25, 2023

Copy link
Copy Markdown
Member Author

@h1alexbel take a look, please. There is update

@l3r8yJ l3r8yJ requested a review from h1alexbel February 25, 2023 13:13
@h1alexbel h1alexbel merged commit 549c573 into eo-cqrs:master Feb 25, 2023
@0pdd

0pdd commented Feb 25, 2023

Copy link
Copy Markdown
Collaborator

@l3r8yJ the puzzle #49 is still not solved.

@h1alexbel

Copy link
Copy Markdown
Member

@l3r8yJ thanks for contribution !

@0pdd

0pdd commented Feb 26, 2023

Copy link
Copy Markdown
Collaborator

@l3r8yJ the puzzle #54 is still not solved; solved: #49.

@l3r8yJ l3r8yJ deleted the packages_consumer branch February 26, 2023 19:33
@0pdd

0pdd commented May 4, 2023

Copy link
Copy Markdown
Collaborator

@l3r8yJ 5 puzzles #294, #295, #296, #297, #298 are still not solved; solved: #49, #54.

@0pdd

0pdd commented Jun 15, 2023

Copy link
Copy Markdown
Collaborator

@l3r8yJ 4 puzzles #294, #295, #297, #unknown are still not solved; solved: #296, #298, #49, #54.

@0pdd

0pdd commented Jun 20, 2023

Copy link
Copy Markdown
Collaborator

@l3r8yJ 3 puzzles #295, #297, #unknown are still not solved; solved: #294, #296, #298, #49, #54.

@0pdd

0pdd commented Jun 21, 2023

Copy link
Copy Markdown
Collaborator

@l3r8yJ 2 puzzles #297, #unknown are still not solved; solved: #294, #295, #296, #298, #49, #54.

@0pdd

0pdd commented Jun 22, 2023

Copy link
Copy Markdown
Collaborator

@l3r8yJ the puzzle #unknown is still not solved; solved: #294, #295, #296, #297, #298, #49, #54.

@0pdd

0pdd commented Jun 27, 2023

Copy link
Copy Markdown
Collaborator

@l3r8yJ all 8 puzzles are solved here: #294, #295, #296, #297, #298, #49, #54, #unknown.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants