Bugfix/142 non numerical values in ods file

[jayr0d]

Bugfix: Update golden files for lofo (lowest in, first out) accounting method and remove check for selected_acquired_lot_amount > taxable_event_amount.

Maintenance:

• Update pre-commit repos and remove additional_dependencies: [black==20.8b1], this avoids issues with:
  • The user requested black==20.8b1, blacken-docs 1.20.0 depends on black>=22.1
  • Failed building wheel for typed-ast
• Updated README.dev.md: update local pre-commit repos
• mypy, black, isort, etc

[macanudo527]

@jayr0d

Looks like you just need to update the config files to delete python 3.8/9

[jayr0d]

Merged and pull request comment updated.

[macanudo527]

@jayr0d
Sorry, but could you explain this bug a little more.

Why did you remove the check for selected_acquired_lot_amount > taxable_event_amount

[jayr0d]

I thought I had enough of those details in #142 already. I guess there are a number of posts to get through. The good one is #142 (comment) I tracked down the offending change. The short of it is Commit 21f9e18 should have never happened and I undid it. The unit tests gold data was inadequate and did not catch the issue that it caused. #142 (comment) is the other good post. There was no LOFO gold data when the issue was introduced and then a gold data set was generated for LOFO based on the bad code. I gave a specific example in the posts following that one where you can easily follow along and see it is not grabbing lots correctly without my changes.

[macanudo527]

LGTM!