#142 follow spec for OTLP protocol #148
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
January 30, 2023 13:31
seems to be cruft leftover from the renovate bot merge
Adds the flag & envvars along with a bunch of tests that mostly fail at this point. Once these all pass it should be good to ship.
Don't try to parse JSON output when command is expected to fail. Initialize empty maps in results so they don't come back as nil in failure tests.
Lots of little adjustments all over. gRPC with http endpoints now works when protocol is grpc. Protocol flag & envvars seem to be fully implemented. Removed mentions of http/json since opentelemetry-go doesn't support it. Updated README to reflect new functionality.
Contributor
Author
|
@cyrille-leclerc can you please take a peek at this PR? |
It doesn't work anyways, will revisit when/if it's needed.
edw-eqix
approved these changes
Jan 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per #142, currently otel-cli doesn't follow the spec around protocols. This PR revises the protocol handling for --endpoint and adds --protocol to more closely or exactly follow the spec.