allow setting attrs at the end of a backgrounded trace #255
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobert
approved these changes
Sep 13, 2023
Contributor
tobert
left a comment
tobert
left a comment
There was a problem hiding this comment.
Perfect, no notes. Thank you!
Contributor
|
OK one note: we should add a test in data_for_test.go to validate this behavior. This will prevent me from breaking it in the future :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to be able to add additional attributes at the end of a backgrounded span, so that outputs from whatever was run during the span could be included.
With this change, attributes which are defined at the start of the span are added to and overwritten by attributes supplied at the end of the span.