fix timeouts #276
Merged
fix timeouts #276
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In my previous PR, I changed otlpclient.retry() to add a deadline when one is missing. This would have been fine if it used the old config.StartupTime but that's gone so I used time.Now(). The problem is, it'll get a new time in the future for every call to retry and never stop. Clearly this needs more testing but for now let's fix it what wasn't broken before.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my previous PR, I changed otlpclient.retry() to add a deadline when one is missing. This would have been fine if it used the old config.StartupTime but that's gone so I used time.Now(). The problem is, it'll get a new time in the future for every call to retry and never stop.
Clearly this needs more testing but for now let's fix it what wasn't broken before.