#81 template traceparent into exec command args #308
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
February 23, 2024 14:00
```
$ go build && TRACEPARENT=00-5b28ee2bf1f1796cca65bef26fb90c35-9d699b596c3dced3-01 ./otel-cli exec --endpoint localhost:4317 -- curl --verbose -H 'traceparent: {{tr
aceparent}}' http://tobert.org
* Trying 45.33.3.11:80...
* Connected to tobert.org (45.33.3.11) port 80 (#0)
> GET / HTTP/1.1
> Host: tobert.org
> User-Agent: curl/7.81.0
> Accept: */*
> traceparent: 00-5b28ee2bf1f1796cca65bef26fb90c35-433d7e8620e9ccea-01
```
tobert
commented
Feb 23, 2024
| config.Attributes["arguments"] = buf.String() | ||
|
|
||
| child = exec.CommandContext(cmdCtx, args[0], args[1:]...) | ||
| child = exec.CommandContext(cmdCtx, args[0], tpArgs...) |
Contributor
Author
There was a problem hiding this comment.
Should there be a command-line arg to enable/disable this feature?
tobert
changed the title
added 4 commits
February 23, 2024 14:25
Not a big deal, but makes a touch more sense.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a feature to
otel-cli execto make it easier to get a traceparent into the child's command line args.solves #306 #81