Skip to content

Refactored Menu component to make it work in sync with dcc.Location #252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

rubenthoms
Copy link
Collaborator

Menu does no longer support a setProps prop - hence, the callbacks can no longer subscribe to its url property. In order to react to changes of the current location, use dcc.Location.

@rubenthoms rubenthoms self-assigned this Sep 13, 2022
@rubenthoms rubenthoms added the enhancement New feature or request label Sep 13, 2022
@rubenthoms rubenthoms marked this pull request as draft September 13, 2022 12:36
Copy link
Collaborator

@jorgenherje jorgenherje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 👍

@rubenthoms rubenthoms marked this pull request as ready for review September 20, 2022 09:17
@rubenthoms rubenthoms merged commit 3ffd848 into equinor:master Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done 🏁
Development

Successfully merging this pull request may close these issues.

2 participants