Skip to content

fix: make triangle line shader consistent with triangle shader #2587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 26, 2025
Merged

fix: make triangle line shader consistent with triangle shader #2587

merged 2 commits into from
Jun 26, 2025

Conversation

w1nklr
Copy link
Collaborator

@w1nklr w1nklr commented Jun 23, 2025

Add DECKGL_FILTER_GL_POSITION to triangle line vertex shader for consistency with triangle vertex shader

@w1nklr w1nklr requested a review from rubenthoms June 23, 2025 08:30
rubenthoms
rubenthoms approved these changes Jun 25, 2025
View reviewed changes
Copy link
Collaborator

@rubenthoms rubenthoms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@w1nklr w1nklr merged commit 32178f0 into equinor:master Jun 26, 2025
13 of 14 checks passed
@w1nklr w1nklr deleted the shaders branch June 26, 2025 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rubenthoms rubenthoms rubenthoms approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@w1nklr @rubenthoms